Re: [PATCH 0/1] Fix UX issue with commit-graph.lock

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2018, 01:28 UTC
Message-ID: <xmqqk1sbhtf1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <3b8005c4-a43d-bd46-c7d9-d6490d500114@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 8 quoted lines

>> Also, can't we tell why we failed to acquire the lock at step #1?
>> Do we only get a NULL that says "I am not telling you why, but we
>> failed to lock"?
>
> To tell why we failed to acquire the lock, we could inspect
> "errno". However, this requires whitebox knowledge of both the
> lockfile API and the tempfile API to know that the last system call to
> set errno was an open() or adjust_shared_perm().

That depends on your viewpoint. We can make it a part of documented API so that we keep the promise of preserving errno in the error codepath when we update these APIs and then you do not have to worry about errno being whitebox knowledge ;-).