Re: [PATCH v2] packfile: Correct zlib buffer handling

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2018, 21:56 UTC
Message-ID: <xmqqk1r25p0s.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAEFTgix0pasg38cb2_qrN+iPgVuq-BX9b7q+qC5Ep9iFbS=Szg@mail.gmail.com>

Jeremy Linton <lintonrjeremy@gmail.com> writes:

Show 20 quoted lines

>> Here is what I tentatively came up with.
>>
>> -- >8 --
>> From: Jeremy Linton <lintonrjeremy@gmail.com>
>> Date: Wed, 13 Jun 2018 09:22:07 -0500
>> Subject: [PATCH] packfile: correct zlib buffer handling
>>
>> The buffer being passed to zlib includes a NUL terminator that git
>> ...
>> +
>>         return buffer;
>>  }
>>
>> --
>> 2.18.0-rc1-1-g6f333ff2fb
>
> This is all fine with me, the original comment was an attempt to
> indicate that the original null may not have been there anymore too..
>
> Shall I resubmit it as above, or can it be picked up like this?

If you are happy with what you saw above, I can just make it no longer "tentative" and use it as-is, which would save time for both of us ;-)

Thanks.