Re: [PATCH v9 2/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875
Max Kirillov <max@max630.net> writes:
Show 13 quoted lines
> On Sat, Aug 04, 2018 at 08:34:08AM +0200, Duy Nguyen wrote:
>> On Fri, Jul 27, 2018 at 5:50 AM Max Kirillov <max@max630.net> wrote:
>>> + if (max_request_buffer < req_len) {
>>> + die("request was larger than our maximum size (%lu): "
>>> + "%" PRIuMAX "; try setting GIT_HTTP_MAX_REQUEST_BUFFER",
>>> + max_request_buffer, (uintmax_t)req_len);
>>
>> Please mark these strings for translation with _().
>
> It has been discussed in [1]. Since it is not a local user
> facing part, probably should not be translated.
>
> [1] https://public-inbox.org/git/20180610150727.GE27650@jessie.local/I'd support that design decision, FWIW.
Junio C Hamano <gitster@pobox.com>