Re: [PATCH] doc: tidy asciidoc style

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 23, 2019, 19:36 UTC
Message-ID: <xmqqk1ivb1yp.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190122201635.15961-1-jn.avila@free.fr>

Jean-Noël Avila <jn.avila@free.fr> writes:

Show 5 quoted lines

> This mainly refers to enforcing indentation on additional lines of
> items of lists.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---

I somehow misread the title as "tiny asciidoc style (fixes)". This is a huge clean-up. Thanks for working on it.

Show 10 quoted lines

> diff --git a/Documentation/git-add.txt b/Documentation/git-add.txt
> index 45652fe4a6..37bcab94d5 100644
> --- a/Documentation/git-add.txt
> +++ b/Documentation/git-add.txt
> @@ -58,9 +58,9 @@ OPTIONS
>  	specifying `dir` will record not just a file `dir/file1`
>  	modified in the working tree, a file `dir/file2` added to
>  	the working tree, but also a file `dir/file3` removed from
> -	the working tree.  Note that older versions of Git used
> +	the working tree). Note that older versions of Git used

Good.

> -	to add modified or new files but ignore removed	ones.
> +	to add modified or new files but ignore removed ones.

For those reading from sidelines, the difference here is that the original has HT between "removed" and "ones" ;-)

Two questions.

 - Does this affect correctness in formatting?  I thought not.

 - How are you finding these?

Show 6 quoted lines

> @@ -206,7 +206,7 @@ EXAMPLES
>  --------
>  
>  * Adds content from all `*.txt` files under `Documentation` directory
> -and its subdirectories:
> +  and its subdirectories:

OK. Just to make sure (read: not an objection to the change), this does not affect the formatted result, right?