Re: [PATCH v4 08/14] commit-graph: add --split option to builtin

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 11, 2019, 19:45 UTC
Message-ID: <xmqqk1drlxde.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2dd1552f-72a3-c676-f46c-1393717ffd82@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 7 quoted lines

> I think the more correct thing to say is that `--split` implies `--append`:
> As we write a new tip graph, we do not discard any commits from the lower
> layers, even if we merge them together.
> ...
> There is nothing that stops them both from being specified, so this
> usage describes a strictness that is not enforced. I can change this
> to be "[--append] [--split]" if that is preferred.

Given that specifying both at the same time does not make much sense, I do not think it makes sense more than "[--append|--split]".

Between erroring out when both are given and following the usual "the last one wins" pattern, I am slightly in favor of the latter.

Thanks.