Re: [PATCH] Makefile: include contrib docs in dist-doc tarballs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 24, 2019, 18:47 UTC
- Message-ID
- <xmqqk1dahlc1.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190623215046.24030-1-robbat2@gentoo.org>
robbat2@gentoo.org writes:
> +.PHONY: dist-doc distclean contrib-doc
I do not think I want to do this.
Contrib are not part of the core because they are not. We do not install their "executable" from the top-level Makefile and I prefer to keep it that way. Why should we ship their documentation ourselves? If somebody wants to build and distribute the contrib material, they should be spending their cycles to also build and distribute the matching docs, not me.
Show 22 quoted lines
> +# subdirs with install-html & install-man targets > +contrib_doc_dirs := contrib/contacts contrib/subtree > +doc_dirs := Documentation $(contrib_doc_dirs) > + > +contrib-doc: > + $(MAKE) -C contrib/svn-fe svn-fe.html svn-fe.1 # no doc target > + for d in $(contrib_doc_dirs) ; do \ > + $(MAKE) -C $$d doc ; \ > + done > + > +dist-doc: doc contrib-doc > $(RM) -r .doc-tmp-dir > mkdir .doc-tmp-dir > - $(MAKE) -C Documentation WEBDOC_DEST=../.doc-tmp-dir install-webdoc > + for d in $(doc_dirs) ; do \ > + $(MAKE) -C $$d \ > + DESTDIR=$(PWD)/ \ > + htmldir=/.doc-tmp-dir/ \ > + install-html ; \ > + done > + : # These files have no install targets > + cp --target .doc-tmp-dir \
"cp --target"??? It may be tempting but I do not think we can rely on it being available everywhere.
> + contrib/subtree/git-subtree.txt \ > + contrib/contacts/git-contacts.txt \ > + contrib/svn-fe/svn-fe.html \ > + contrib/svn-fe/svn-fe.txt