git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-rebase.txt: add another hook to the hooks section, and explain more

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 3, 2020, 19:35 UTC
Message-ID
<xmqqk12wz7jv.fsf@gitster.c.googlers.com>
In-Reply-To
<pull.749.git.git.1585888520572.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
>  The apply backend has not traditionally called the post-commit hook,
> +while the merge backend has.  In contrast, the apply backend has
> +traditionally called the post-checkout hook while the merge backend
> +has not.  However, the calling of these hooks in both cases was by
> +accident of implementation rather than by design (both backends were
> +originally implemented as shell scripts and happened to invoke other
> +commands like 'git checkout' or 'git commit' that would call the
> +hooks).  Both backends should have the same behavior, though it is not
> +entirely clear which, if any, is correct.  We will likely remove both
> +of these hooks in the future.

I'd phrase, instead of "remove", "stop calling from 'git rebase'". These hooks will still be called from their intended context ;-)

Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren
Message 2 of 6 in “git-rebase.txt: add another hook to the hooks section, and explain more”
  1. git-rebase.txt: add another hook to the hooks section, and explain moreElijah Newren via GitGitGadget, Apr 3, 2020
  2. Junio C HamanoApr 3, 2020
  3. Elijah NewrenApr 3, 2020
  4. git-rebase.txt: add another hook to the hooks section, and explain moreElijah Newren via GitGitGadget, Apr 4, 2020
  5. Phillip WoodApr 4, 2020
  6. git-rebase.txt: add another hook to the hooks section, and explain moreElijah Newren via GitGitGadget, Apr 5, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.