Re: [PATCH] git-rebase.txt: add another hook to the hooks section, and explain more
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 3, 2020, 19:35 UTC
- Message-ID
- <xmqqk12wz7jv.fsf@gitster.c.googlers.com>
- In-Reply-To
- <pull.749.git.git.1585888520572.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> The apply backend has not traditionally called the post-commit hook, > +while the merge backend has. In contrast, the apply backend has > +traditionally called the post-checkout hook while the merge backend > +has not. However, the calling of these hooks in both cases was by > +accident of implementation rather than by design (both backends were > +originally implemented as shell scripts and happened to invoke other > +commands like 'git checkout' or 'git commit' that would call the > +hooks). Both backends should have the same behavior, though it is not > +entirely clear which, if any, is correct. We will likely remove both > +of these hooks in the future.
I'd phrase, instead of "remove", "stop calling from 'git rebase'". These hooks will still be called from their intended context ;-)