Re: [PATCH v3 3/3] git-prompt: include sparsity state as well

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 22, 2020, 16:35 UTC
Message-ID: <xmqqk0zzdpnt.fsf@gitster.c.googlers.com>
In-Reply-To: <d99202f8e1443f517b16811b7d2ba2593898e9d0.1592716887.git.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines

> From: Elijah Newren <newren@gmail.com>
> ...
> The reason for showing the "|SPARSE" substring before other states is to
> ...
> The fact that sparsity isn't just cached metadata or additional
> information is what leads us to show it more similarly to the
> in-progress states, but the fact that sparsity is not transient like the
> in-progress states might cause some users to want an abbreviated
> notification of sparsity state or perhaps even be able to turn it off.
> Allow GIT_PS1_COMPRESSSPARSESTATE to be set to request that it be
> shortened to a single character ('?'), and GIT_PS1_OMITSPARSESTATE to be
> set to request that sparsity state be omitted from the prompt entirely.

Nicely explained. It somewhat feels a bit overkill to have two (i.e. compress vs omit) knobs---the other "semi-permanent" state that may be of interest but could become too noisy only have one knob that toggles between showing a short-and-non-intrusive sign and not showing anything at all with GIT_PS1_SHOWSTASHSTATE, and that smells like a better balance to me, but I dunno.

Thanks.  Will queue.