Re: [PATCH] upload-pack: do not lazy-fetch "have" objects

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 16, 2020, 17:36 UTC
Message-ID: <xmqqk0z3gy5y.fsf@gitster.c.googlers.com>
In-Reply-To: <20200716104149.GA376357@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> I think the instance fixed here _probably_ could be converted to QUICK
> as well. It saves extra refreshes of the pack directory when a client
> asks for an object we don't have. That's usually not too expensive, but
> can be in some cases (many alternates, slow NFS filesystems, client has
> many objects we don't). In the worst case, using QUICK would mean we can
> get fooled by a simultaneous repack into thinking we don't have an
> object we _do_ have, and end up negotiating a worse pack for the client.
>
>> Thanks.  Will queue.
>
> That said, yeah, I think Jonathan's patch is a strict improvement by
> itself.

I'll see what Jonathan would say, hoping that he'd consider if QUICK is appropriate or not sufficiently enough to result in an updated patch, that either has QUICK in the code or the reason why QUICK is not used in the log message.

Thanks.