Re: [PATCH] archive: convert queue_directory to struct object_id
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 27, 2021, 21:18 UTC
- Message-ID
- <xmqqk0k6a8n7.fsf@gitster.g>
- In-Reply-To
- <YSlN0+ZCpDqoem9J@camp.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 5 quoted lines
> On 2021-08-27 at 19:59:16, René Scharfe wrote: >> Pass the struct object_id on instead of just its hash member. >> This is simpler and avoids the need to guess the algorithm. > > Seems reasonable.
I guess this is about the oidread() you added at the end of the function, so I'd take the above as your Acked-by ;-)
Thanks, both. Will queue.