git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] trace2 docs: a couple of grammar fixes

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 10, 2022, 18:55 UTC
Message-ID
<xmqqk0d1eixc.fsf@gitster.g>
In-Reply-To
<220310.86ilslkh6n.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 21 quoted lines
> On Thu, Mar 10 2022, Johannes Schindelin via GitGitGadget wrote:
>
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> ---
>>  Documentation/technical/api-trace2.txt | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt
>> index bb13ca3db8b..77216eff622 100644
>> --- a/Documentation/technical/api-trace2.txt
>> +++ b/Documentation/technical/api-trace2.txt
>> @@ -24,7 +24,7 @@ for example.
>>  
>>  Trace2 is controlled using `trace2.*` config values in the system and
>>  global config files and `GIT_TRACE2*` environment variables.  Trace2 does
>> -not read from repo local or worktree config files or respect `-c`
>> +not read from repo local or worktree config files nor does it respect `-c`
>
> Perhaps adding a comma before "nor" would also be a good addition.
Yup, that sounds sensible.  All other hunks looked good, too.
Thanks, both.
Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 4 of 19 in “A couple of fixes for the Trace2 documentation”
  1. 0/4 A couple of fixes for the Trace2 documentationJohannes Schindelin via GitGitGadget, Mar 10, 2022
  2. 1/4 trace2 docs: a couple of grammar fixesJohannes Schindelin via GitGitGadget, Mar 10, 2022
  3. Ævar Arnfjörð BjarmasonMar 10, 2022
  4. Junio C HamanoMar 10, 2022
  5. Junio C HamanoMar 10, 2022
  6. 2/4 trace2 docs: surround more terms in backticksJohannes Schindelin via GitGitGadget, Mar 10, 2022
  7. Junio C HamanoMar 10, 2022
  8. 3/4 trace2 docs: fix a JSON formatted exampleJohannes Schindelin via GitGitGadget, Mar 10, 2022
  9. 4/4 trace2 docs: clarify what `varargs` is all aboutJohannes Schindelin via GitGitGadget, Mar 10, 2022
  10. Ævar Arnfjörð BjarmasonMar 10, 2022
  11. Jeff HostetlerMar 10, 2022
  12. 0/6 A couple of fixes for the Trace2 documentationJohannes Schindelin via GitGitGadget, May 3, 2022
  13. 1/6 trace2 docs: a couple of grammar fixesJohannes Schindelin via GitGitGadget, May 3, 2022
  14. 2/6 trace2 docs: "printf" is not an English wordJohannes Schindelin via GitGitGadget, May 3, 2022
  15. 6/6 trace2 docs: add missing full stopJohannes Schindelin via GitGitGadget, May 3, 2022
  16. 5/6 trace2 docs: clarify what `varargs` is all aboutJohannes Schindelin via GitGitGadget, May 3, 2022
  17. 3/6 trace2 docs: surround more terms in backticksJohannes Schindelin via GitGitGadget, May 3, 2022
  18. 4/6 trace2 docs: fix a JSON formatted exampleJohannes Schindelin via GitGitGadget, May 3, 2022
  19. Jeff HostetlerMay 3, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.