Re: [PATCH v2] config: introduce an Operating System-specific `includeIf` condition

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2022, 07:31 UTC
Message-ID: <xmqqk03jcwxz.fsf@gitster.g>
In-Reply-To: <969a4399-a6db-7c72-f96c-8bbe5f6208d4@iee.email>

Philip Oakley <philipoakley@iee.email> writes:

Show 8 quoted lines

>> Let's introduce a new condition: `os:<uname-s>` where `<uname-s>` is the
>> system name, i.e. the output of `uname -s`.
>
> This `uname -s` doesn't work well on Git-for-Windows (GfW) / Windows
> because GfW has its own internal compatibility code to spoof the result.
> ...
> Or just drop the mentions of "<uname-s>" in this commit message and
> rename it 'sysname' to match the field of the struct utsname?

FWIW I do not mind "sysname".  It is much better to say

	[includeIf "sysname:Linux"] path = ...

than "os:Linux", as "sysname" informs us the granularity used to identify the system better than "os".