Re: [PATCH v2 1/2] diff: consolidate diff algorithm option parsing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 16, 2023, 02:57 UTC
- Message-ID
- <xmqqk00itj0c.fsf@gitster.g>
- In-Reply-To
- <Y+2RgdCDrDC1N9Y1@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> I'd have expected it with individual callbacks like:
>
> int handle_patience(...)
> {
> do_patience_specific_stuff();
> do_shared_stuff(PATIENCE_DIFF);
> }
>
> int handle_histogram(...)
> {
> do_shared_stuff(HISTOGRAM_DIFF);
> }
>
> and so on. That's a bit more verbose, but the call stack reflects the
> flow we expect.Exactly.
Thanks for spelling it out.