Re: [PATCH 1/4] apply: plug a leak in apply_data

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 22, 2024, 22:27 UTC
Message-ID: <xmqqjzkpt4n2.fsf@gitster.g>
In-Reply-To: <78f38e0f-7456-42d7-b0d1-887944bb01c9@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 12 quoted lines

>> So the leak existed before that commit. Indeed it looks
>> like the leak predates the introduction of struct image in b94f2eda99
>> (builtin-apply.c: make it more line oriented, 2008-01-26) and when
>> the patch does not apply we have been leaking the buffer passed to
>> apply_fragments() since the beginning of the builtin apply added in
>> ac6245e31a3 (Builtin git-apply., 2006-05-23)
>
> You are very right.
>
> I saw that commit.  I reviewed again my notes and I recorded the hash of
> the previous hop;  the one that my message, incorrectly, refers to.
> I'll reroll to fix it.

FWIW, the very first version of apply_one_fragment() in 3cca928d (git-apply: first cut at actually checking fragment data, 2005-06-05) already had leak; it "returns -1" upon an error without freeing old/new buffers. Over the years, the shape of the code changed, but the leak survived.