Re: Combined diff format: Show all filenames by default?

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2024, 19:42 UTC
Message-ID: <xmqqjzka65ry.fsf@gitster.g>
In-Reply-To: <CADDzAfPbSv00AfzdJ5DZbXM8YjAr=po6Y_1Y0weyw5dvVA6qFg@mail.gmail.com>

Kang-Che Sung <explorer09@gmail.com> writes:

Show 6 quoted lines

>> As the format HAS ALREADY lasted for a long time since its
>> introduction in d8f4790e (diff-tree --cc: denser combined diff
>> output for a merge commit., 2006-01-24), it is too late to change
>> the default.
>
> I wonder what things would break if we change the default behavior of this?

Human users who rarely if ever rename files will start complaining for wasted vertical screen real estates taken by the extra lines.

Nothing is broken, and you are proposing to break things. Be more gentle to existing users; "what would break if we change?" is an absolutely wrong attitude to approach this.

> Well, I won't expect the default to be changed for uses in scripts or
> GUI frontends. I wish to change the default for interactive, terminal
> uses, so that usability comes in "out of the box".

How would a script that is running by interactive users whose standard input and output streams are connected to a terminal adjust to sudden change of the default? The "git" invocation in such an environment would not be able to tell if you typed it or if you typed the name of the script.