git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t0211-trace2-perf.sh: typo patern -> pattern

From
Junio C Hamano <gitster@pobox.com>
Date
May 15, 2024, 16:52 UTC
Message-ID
<xmqqjzjvxbk0.fsf@gitster.g>
In-Reply-To
<ZkTIPlTS4jcQ-rHX@telcontar>
Marcel Telka <marcel@telka.sk> writes:
Show 16 quoted lines
> Hi,
>
> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:
>
>
> --- a/t/t0211-trace2-perf.sh
> +++ b/t/t0211-trace2-perf.sh
> @@ -233,7 +233,7 @@ have_counter_event () {
>  
>         pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>  
> -       grep "${patern}" ${file}
> +       grep "${pattern}" ${file}
>  }
>  
>  test_expect_success 'global counter test/test1' '

Ah, indeed, there is no assignment to the variable $patern so this grep matches by looking for all the empty strings in the file X-<.

Previous: Marcel TelkaNext: Jeff Hostetler
Message 2 of 4 in “t0211-trace2-perf.sh: typo patern -> pattern”
  1. Marcel TelkaMay 15, 2024
  2. Junio C HamanoMay 15, 2024
  3. Jeff HostetlerMay 15, 2024
  4. Junio C HamanoMay 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.