Re: [PATCH 2/2] pack-bitmap.c: ensure pseudo-merge offset reads are bounded

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 6, 2024, 22:35 UTC
Message-ID: <xmqqjzj1k8c8.fsf@gitster.g>
In-Reply-To: <ZmI3RYSsx6VRHdc9@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 7 quoted lines

> On Thu, Jun 06, 2024 at 12:42:59PM -0700, Junio C Hamano wrote:
>> Can table_size at this point be smaller than 24, which will allow
>> (table_size - 24) to be a huge number that st_mult() will
>> comfortably fit?
>
> It could be smaller than 24, but I think we're at the point of
> diminishing returns here.

I only meant to say that we could easily rewrite

	if (st_mult() > table_size - 24)

condition to

	if (st_add(st_mult(), 24) > table_size)

and we do not have to think if we have already checked table_size before we reach this point of the control flow.