Re: [PATCH 2/2] server-info.c: remove temporary info files on exit

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 7, 2024, 21:49 UTC
Message-ID: <xmqqjzj0e84x.fsf@gitster.g>
In-Reply-To: <ZmN/NZlriT3gsw7p@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 8 quoted lines

>> We no longer do so.  We later call rename_tempfile() to close the
>> underlying file descriptor and move the temporary file to its final
>> place, but I do not see what guarantee we have that we do not lose
>> what we had buffered in the stdio with the updated code.
>
> rename_tempfile() first calls close_tempfile_gently() before calling
> rename(). close_tempfile_gently() calls fclose() on temp->fp before
> returns, so we get our fflush() call implicitly there.

OK.  I didn't see that fclose().  Then we are safe.

Thanks.