Re: [PATCH 2/4] attr: notice and report read failure of .gitattributes files

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 20, 2024, 16:20 UTC
Message-ID: <xmqqjzijy4a0.fsf@gitster.g>
In-Reply-To: <20240619135754.GB943023@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I don't know that this is really consistent with callers of fopen(),
> since they tend to complain noisily. Usually via warn_on_fopen_errors(),
> which we ourselves call above.

Argh, you're right. I thought the guard in warn_on_fopen_errors() would catch the artificial error code we give when we found that we opened a directory (by mistake), but the error we use is EISDIR, so it will be shown.

OK, let's scrap the whole thing. It does not look like it is solving any real-world problems.

Thanks.