git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: drop use of 'tee' that hides exit status

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 9, 2024, 01:25 UTC
Message-ID
<xmqqjzgqfpxo.fsf@gitster.g>
In-Reply-To
<93e6fdd3-4a15-4cc5-929a-aa5e79f44e1c@gmail.com>
Rubén Justo <rjusto@gmail.com> writes:
Show 5 quoted lines
>> In none of these tests, I do not see a reason why we want to hide a
>
> This double negative caught my attention.  The message is
> understandable; perhaps "In none of these tests I see ..." would have
> been clearer.

You're absolutely right, and it is not just "would have been clearer"---your fix makes a nonsense double-negation into a correct sentence. I'd go with "In any of ... I do not see" while queuing.

Thanks.
Previous: Rubén JustoNext: Johannes Schindelin
Message 3 of 6 in “tests: drop use of 'tee' that hides exit status”
  1. tests: drop use of 'tee' that hides exit statusJunio C Hamano, Aug 8, 2024
  2. Rubén JustoAug 9, 2024
  3. Junio C HamanoAug 9, 2024
  4. Johannes SchindelinAug 13, 2024
  5. Jeff KingAug 13, 2024
  6. Junio C HamanoAug 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.