Re: [EXT] [PATCH v2 1/5] add-patch: improve help for options j, J, k, and K

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2025, 08:18 UTC
Message-ID: <xmqqjz0axj1i.fsf@gitster.g>
In-Reply-To: <697bf0301cd9459195bdd3cc79e517ae@ukr.de>

"Windl, Ulrich" <u.windl@ukr.de> writes:

Show 6 quoted lines

> For the patch
> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> index ad629c46c5..3266ccf105 100644
>
> I don't see an actual improvement, and I'd prefer the previous
> version of the doc.

We'd prefer to see something more concrete that refuses the reasoning that led to the change, than a subjective "I don't see, I'd prefer".

At least, the commit log messge given by 2c3cc43f (add-patch: improve help for options j, J, k, and K, 2025-10-06) explains why the change is an improvement, and I found it sensible. (<b5034851-65bd-49da-b270-48b68d9210ff@web.de>)

The old description said 'j' leaves this hunk undecided and goes to the next undecided hunk, but it is both pointless and misleading to say 'leave this hunk undecided'. Unlike 'y' or 'n', the movement options 'j', 'k' are not about changing the state of the current thing we are on (so it is pointless to say "LEAVE it undecided"), and more importantly, when we say 'j', the state of the current thing we are on may not necessarily be 'undecided' (so it is misleading to say "leave it UNDECIDED").