git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/1] environment: move protect_hfs and protect_ntfs into repo_config_values

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 19, 2026, 17:25 UTC
Message-ID
<xmqqjyrujvco.fsf@gitster.g>
In-Reply-To
<xmqqo6h6jvuk.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> diff --git c/environment.h w/environment.h
> index fdd9775900..b1ae4a70de 100644
> --- c/environment.h
> +++ w/environment.h
> @@ -127,8 +127,8 @@ int git_default_core_config(const char *var, const char *value,
>  
>  /*
>   * Getters for the `protect_hfs` and `protect_ntfs` fields of `struct repo_config_values`.
> - * They check `repo->gitdir` to prevent calling repo_config_values()
> - * before the configuration is loaded or in bare environments.
> + * They check `repo->initialized` to prevent calling `repo_config_values()`
> + * before the repository setup is fully complete or in non-git environments.
>   */
>  int repo_protect_hfs(struct repository *repo);
>  int repo_protect_ntfs(struct repository *repo);

Another thing we should remember (but should *NOT* do while these topics are still in flight) to do is to consolidate these comments into one. The hfs and htfs getters are covered by the same single comment, but ignorecase and trustexecutable bit getters have their own comments, only because they came in different topics. We should conslidate them into a single comment block once all of these have landed in 'master', which may happen soon after 2.55 final gets tagged.

Previous: Junio C HamanoNext: Tian Yuchen
Message 4 of 7 in “environment: move protect_hfs and protect_ntfs into repo_config_values”
  1. 0/1 environment: move protect_hfs and protect_ntfs into repo_config_valuesTian Yuchen, Jun 19, 2026
  2. 1/1 environment: move 'protect_hfs' and 'protect_ntfs' into 'repo_config_values'Tian Yuchen, Jun 19, 2026
  3. Junio C HamanoJun 19, 2026
  4. Junio C HamanoJun 19, 2026
  5. Tian YuchenJun 20, 2026
  6. environment: use 'repo->initialized' for repo_protect_hfs() and repo_protect_ntfs()Tian Yuchen, Jun 20, 2026
  7. Junio C HamanoJun 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.