git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision: make get_commit_action() a pure predicate

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 24, 2026, 21:37 UTC
Message-ID
<xmqqjyqk3w7d.fsf@gitster.g>
In-Reply-To
<pull.2169.git.1784143793613.gitgitgadget@gmail.com>
"Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 11 quoted lines
> Add a "line-log-peek" subcommand to the revision-walking test helper
> that evaluates get_commit_action() on a commit the walk has not reached
> yet, plus a t4211 check that the call leaves the commit's flags
> unchanged.  The flags are compared rather than the commit list because
> add_line_range() merges ranges by union, which is idempotent, so the
> side effect never changed which commits a linear -L history shows.
>
> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Michael Montalbo <mmontalbo@gmail.com>
> ---
>     revision: make get_commit_action() a pure predicate

Sorry, but I completely lost track and I do not recall suggesting a change that amounts to 100+ lines of new lines. Are we doing any code clean-up? Bugfix? A new feature?

Previous: Michael Montalbo via GitGitGadgetNext: Michael Montalbo
Message 2 of 5 in “revision: make get_commit_action() a pure predicate”
  1. revision: make get_commit_action() a pure predicateMichael Montalbo via GitGitGadget, Jul 15, 2026
  2. Junio C HamanoJul 24, 2026
  3. Michael MontalboJul 25, 2026
  4. Junio C HamanoJul 27, 2026
  5. Junio C HamanoJul 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.