git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 07/14] odb: gather the odb sources under odb/

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 24, 2026, 14:43 UTC
Message-ID
<xmqqjypfshnh.fsf@gitster.g>
In-Reply-To
<aoxQaSGaDwqkP7Tb@ugly.lan>
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
Show 14 quoted lines
> On Sun, Aug 23, 2026 at 10:18:51AM -0700, Michael Montalbo wrote:
>>Move the 23 odb C sources and 26 headers into odb/ as renames.
>>
> i for one would go with lib/odb/.
>
>>+++ b/builtin/add.c
>>-#include "object-file.h"
>>-#include "odb.h"
>>+#include "odb/object-file.h"
>>+#include "odb/odb.h"
>> 
> that's the wrong include style here.
> it was already wrong in a lot of places, but as you rewrite everything 
> anyway, you could fix it just as well.

I do not agree with lib/odb/ suggestion, but I am curious what you think the "right" include stle is, because I cannot read it out of what you have written. Please do not assume that everybody knows what you think is right or wrong.

Do you mean they should not be quoted in a pair of double quotes because the behaviour of such includes is implementation-defined (instead use "<>" as we use -I<path> on the command line)? Do you mean they should be alphabetical? Something else?

Thanks.
Previous: Oswald BuddenhagenNext: Oswald Buddenhagen
Message 11 of 18 in “git organize: record file placement and apply it”
  1. 00/14 git organize: record file placement and apply itMichael Montalbo, Aug 23, 2026
  2. 01/14 organize: add the git organize builtinMichael Montalbo, Aug 23, 2026
  3. 03/14 organize: add status --exit-codeMichael Montalbo, Aug 23, 2026
  4. 02/14 organize: add the labeler, organizer, and apply --labels-onlyMichael Montalbo, Aug 23, 2026
  5. 04/14 organize: add the --label selectorMichael Montalbo, Aug 23, 2026
  6. 05/14 organize: declare Git's scope and layoutMichael Montalbo, Aug 23, 2026
  7. 06/14 organize: record a label for every source in scopeMichael Montalbo, Aug 23, 2026
  8. 08/14 refs: gather the refs sources under refs/Michael Montalbo, Aug 23, 2026
  9. 07/14 odb: gather the odb sources under odb/Michael Montalbo, Aug 23, 2026
  10. Oswald BuddenhagenAug 24, 2026
  11. Junio C HamanoAug 24, 2026
  12. Oswald BuddenhagenAug 24, 2026
  13. 09/14 pack: gather the pack sources under pack/Michael Montalbo, Aug 23, 2026
  14. 10/14 diff: gather the diff sources under diff/Michael Montalbo, Aug 23, 2026
  15. 11/14 revision: gather the revision sources under revision/Michael Montalbo, Aug 23, 2026
  16. 12/14 index: gather the index sources under index/Michael Montalbo, Aug 23, 2026
  17. 13/14 setup: gather the setup sources under setup/Michael Montalbo, Aug 23, 2026
  18. 14/14 transport: gather the transport sources under transport/Michael Montalbo, Aug 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.