Re: [PATCH] tag: Use OPT_BOOL instead of OPT_BOOLEAN to allow one action multiple times
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 18, 2013, 09:27 UTC
- Message-ID
- <xmqqioz3e4cw.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20130817203458.GB2904@elie.Belkin>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 19 quoted lines
> Stefano Lattarini wrote: > >> Why not encourage the use of a standardized '--action' option instead? > > Because it's an unpleasant UI. :) > >> This can work with lesser compatibility headaches for both the commands >> taking mode options and the commands taking mode words: >> >> "git submodule init" becomes "git submodule --action=init" >> "git tag --delete TAG" becomes "git tag --action=delete TAGNAME" > > That looks like a bad change in both cases --- it involves more > typing without much upside to go along with it. But > > "git submodule init" gains synonym "git submodule --init" > "git tag --delete TAG" stays as "git tag --delete TAG" > > looks fine to me.
I agree 100% with the above that illustrates why --action=<name> is a bad idea. As I already said, adding action-option like --init, if doing so might help people, I am not opposed to it.
Thanks.