Re: [PATCH] update-index: fix segfault with missing --cacheinfo argument

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2014, 18:03 UTC
Message-ID: <xmqqioogv9ge.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140604071110.GA22158@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> Running "git update-index --cacheinfo" without any further
> arguments results in a segfault rather than an error
> message. Commit ec160ae (update-index: teach --cacheinfo a
> new syntax "mode,sha1,path", 2014-03-23) added code to
> examine the format of the argument, but forgot to handle the
> NULL case.
>
> Returning an error from the parser is enough, since we then
> treat it as an old-style "--cacheinfo <mode> <sha1> <path>",
> and complain that we have less than 3 arguments to read.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---

Thanks.