Re: [PATCH] git-prompt.sh: shorter equal upstream branch name
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 7, 2014, 20:10 UTC
- Message-ID
- <xmqqiojvej49.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <54340D63.8030507@gmail.com>
Julien Carsique <julien.carsique@gmail.com> writes:
Show 11 quoted lines
> Hi, > > Thank you both for your feedback! > I'm looking at applying your requests: > - add tests, > - variable renaming, > - use of local, > - fix multiple issues on string parsing > - avoid useless bash-isms? Did you agree on the ones I should remove? > > I'll send an updated patch asap. Tell me if I forgot something.
I just re-read the comments in the thread, and a few things look missing:
- git-svn? - conditionally enable this feature?
Other than that the above list looks like a fairly good one.
Thanks.