Re: [PATCH] configure.ac: quote AC_PREREQ in configure.ac

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 31, 2014, 19:55 UTC
Message-ID: <xmqqioj0t3ne.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1414765046-15703-1-git-send-email-gitter.spiros@gmail.com>

Elia Pinto <gitter.spiros@gmail.com> writes:

> For a old bug autoupdate don't do it before autoconf v2.66

I am having a hard time parsing this.

What is the practical issue that comes from the lack of quoting here? It won't be like somebody defines a macro to allow 2.59 to expand to something else, confusing the machinery, so...?

Show 19 quoted lines

>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 6af9647..9f01999 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -141,7 +141,7 @@ fi
>  
>  ## Configure body starts here.
>  
> -AC_PREREQ(2.59)
> +AC_PREREQ([2.59])
>  AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org])
>  
>  AC_CONFIG_SRCDIR([git.c])