git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/3] builtin/log.c: minor reformat

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 21, 2015, 18:03 UTC
Message-ID
<xmqqio885xjz.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1440110591-12941-1-git-send-email-gitster@pobox.com>

Two logical lines that were not overly long was split in the middle, which made them read worse.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/log.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 0cdd889..a491d3d 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -342,8 +342,7 @@ static int cmd_log_walk(struct rev_info *rev)
 	 * retain that state information if replacing rev->diffopt in this loop
 	 */
 	while ((commit = get_revision(rev)) != NULL) {
-		if (!log_tree_commit(rev, commit) &&
-		    rev->max_count >= 0)
+		if (!log_tree_commit(rev, commit) && rev->max_count >= 0)
 			/*
 			 * We decremented max_count in get_revision,
 			 * but we didn't actually show the commit.
@@ -1464,8 +1463,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
 			continue;
 		}
 
-		if (ignore_if_in_upstream &&
-				has_commit_patch_id(commit, &ids))
+		if (ignore_if_in_upstream && has_commit_patch_id(commit, &ids))
 			continue;
 
 		nr++;
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “Showing merges easier with "git log"”
  1. 0/3 Showing merges easier with "git log"Junio C Hamano, Aug 20, 2015
  2. 1/3 log: rename "tweak" helpersJunio C Hamano, Aug 20, 2015
  3. 2/3 log: when --cc is given, default to -p unless told otherwiseJunio C Hamano, Aug 20, 2015
  4. 3/3 log: show merge commit when --cc is givenJunio C Hamano, Aug 20, 2015
  5. 4/3 builtin/log.c: minor reformatJunio C Hamano, Aug 21, 2015
  6. log: make '-p' imply '-m --cc'Junio C Hamano, Aug 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.