git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 01/10] ref-filter: introduce a parsing function for each atom in valid_atom

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 11, 2015, 22:18 UTC
Message-ID
<xmqqio44eijo.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAOLa=ZTHaety8=cxP4PqcXqrRv9OAEAcRyTs9drY6nSFGKvyOQ@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 6 quoted lines
>> This problem will go away if you introduce the 'valid_atom' field in
>> the patch which actually needs it (as suggested above) rather than in
>> this patch.
>
> Yup, agreed.
> Thanks for your suggestions.

In addition, most of the lines in this patch should become unnecessary even after you start using the "parser" field.

As the majority of fields are compared as strings, and only a selected few fields need custom parsers, you do not have to explicitly write FIELD_STR everywhere, as long as you make sure the value of FIELD_STR is zero (and use parser==NULL as a sign that no custom parser is used, which I think you already do).

Previous: Karthik NayakNext: Karthik Nayak
Message 7 of 50 in “ref-filter: use parsing functions”
  1. 00/10 ref-filter: use parsing functionsKarthik Nayak, Nov 11, 2015
  2. 01/10 ref-filter: introduce a parsing function for each atom in valid_atomKarthik Nayak, Nov 11, 2015
  3. Eric SunshineNov 23, 2015
  4. Karthik NayakNov 25, 2015
  5. Eric SunshineNov 25, 2015
  6. Karthik NayakNov 26, 2015
  7. Junio C HamanoDec 11, 2015
  8. Karthik NayakDec 12, 2015
  9. 02/10 ref-filter: introduce struct used_atomKarthik Nayak, Nov 11, 2015
  10. Eric SunshineDec 1, 2015
  11. 03/10 ref-fitler: bump match_atom() name to the topKarthik Nayak, Nov 11, 2015
  12. 04/10 ref-filter: skip deref specifier in match_atom_name()Karthik Nayak, Nov 11, 2015
  13. Eric SunshineDec 1, 2015
  14. Karthik NayakDec 3, 2015
  15. 05/10 ref-filter: introduce color_atom_parser()Karthik Nayak, Nov 11, 2015
  16. Eric SunshineDec 1, 2015
  17. Karthik NayakDec 3, 2015
  18. Eric SunshineDec 13, 2015
  19. Karthik NayakDec 13, 2015
  20. 06/10 strbuf: introduce strbuf_split_str_without_term()Karthik Nayak, Nov 11, 2015
  21. Eric SunshineDec 2, 2015
  22. Karthik NayakDec 3, 2015
  23. Junio C HamanoDec 11, 2015
  24. Karthik NayakDec 12, 2015
  25. 07/10 ref-filter: introduce align_atom_parser()Karthik Nayak, Nov 11, 2015
  26. Eric SunshineDec 2, 2015
  27. Karthik NayakDec 7, 2015
  28. 08/10 ref-filter: introduce remote_ref_atom_parser()Karthik Nayak, Nov 11, 2015
  29. Eric SunshineDec 13, 2015
  30. Karthik NayakDec 13, 2015
  31. Eric SunshineDec 13, 2015
  32. Karthik NayakDec 13, 2015
  33. Eric SunshineDec 13, 2015
  34. Karthik NayakDec 13, 2015
  35. 09/10 ref-filter: introduce contents_atom_parser()Karthik Nayak, Nov 11, 2015
  36. Eric SunshineDec 13, 2015
  37. Eric SunshineDec 13, 2015
  38. Karthik NayakDec 13, 2015
  39. Karthik NayakDec 13, 2015
  40. Jeff KingNov 24, 2015
  41. Karthik NayakNov 25, 2015
  42. 10/10 ref-filter: introduce objectname_atom_parser()Karthik Nayak, Nov 25, 2015
  43. Eric SunshineDec 13, 2015
  44. Karthik NayakDec 13, 2015
  45. Junio C HamanoDec 11, 2015
  46. Eric SunshineDec 13, 2015
  47. Karthik NayakDec 13, 2015
  48. Eric SunshineDec 13, 2015
  49. Karthik NayakDec 16, 2015
  50. Junio C HamanoDec 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.