Re: [PATCH 2/2] merge: warn --no-commit merge when no new commit is created

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2016, 15:13 UTC
Message-ID: <xmqqinz3axvc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1604270846430.2896@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 5 quoted lines

> I am not sure about this double negation "no_commit_impossible" (I only
> understood what you meant because I had read the commit message first,
> something I won't do when stumbling over this code later).
>
> Maybe something like `disallow_no_commit`?

That would be the best name once we start dying in there. It might be still better, even while we merely warn but let it pass, than the double negative. Or it may not. I dunno.