Re: [PATCH v2] git-p4: Fix git-p4.mapUser on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2017, 17:07 UTC
Message-ID: <xmqqinowwk6q.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAE5ih7-qug9n-Df2gA27iTjSQo67tAnPhTJWQhyvR_PP9h3rcg@mail.gmail.com>

Luke Diamand <luke@diamand.org> writes:

Show 12 quoted lines

> On 27 January 2017 at 17:33, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Luke, Lars, this version seems to be in line with the conclusion of
>> your earlier reviews, e.g.
>>
>> <CAE5ih7_+Vc9oqKdjo8h2vgZPup4pto9wd=sBb=W6hCs4tuW2Jg@mail.gmail.com>
>>
>> Even though it looks OK to my eyes, I'll wait for Acks or further
>> refinement suggestions from either of you two before acting on this
>> patch.
>
> It looks good to me. The tests all pass, and the change looks correct.

Thanks, queued.