git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Incorrect Diff!

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 2, 2017, 04:55 UTC
Message-ID
<xmqqinkfyonc.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAJ-kjL-Y+x-ZROnNm+Ray54hwxfkA6K6uxYoUVQpa3NmrzbEMg@mail.gmail.com>
Pulkit Goyal <7895pulkit@gmail.com> writes:
Show 9 quoted lines
> I was working on a Django project when I got the following diff which
> is very much confusing.
>
> The diff is pasted at https://bpaste.net/show/c2cb00728ff0.
>
> As you can see on bpaste that in line number 9,10 I have changed
> "class activationview" to "class activateuser", but in line number 14
> the diff is again showing me "class activationview". Maybe Git is
> trying to be smart here, but the diff is wrong and I was confused.
I do not think Git is trying to be smart at all.  

The function context lines @@ .. @@ consistently is showing the name in the preimage of the diff, no?

The function/class header that appears in the preimage before the hunk that begins at line 108 is activationview and that is shown there. So is the header on the hunk that begins at line 149.

So there is nothing remarkable in this patch as far as I can see.
Previous: Pulkit Goyal
Message 2 of 2 in “Incorrect Diff!”
  1. Pulkit GoyalJun 2, 2017
  2. Junio C HamanoJun 2, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.