git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: camelCase the i18n config variables to improve readability

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 17, 2017, 22:12 UTC
Message-ID
<xmqqiniqg1bc.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170717153900.16666-1-kaarticsivaraam91196@gmail.com>
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
Show 8 quoted lines
> The i18n config variable used weren't readable as they were in
> the crude form of how git stores/uses it's config variables.
>
> Improve it's readability by replacing them with camelCased versions
> of config variables as it doesn't have any impact on it's usage.
>
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
Thanks; this makes sense.
Show 40 quoted lines
>  Documentation/i18n.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/i18n.txt b/Documentation/i18n.txt
> index 2dd79db5c..7e36e5b55 100644
> --- a/Documentation/i18n.txt
> +++ b/Documentation/i18n.txt
> @@ -42,11 +42,11 @@ mind.
>  +
>  ------------
>  [i18n]
> -	commitencoding = ISO-8859-1
> +	commitEncoding = ISO-8859-1
>  ------------
>  +
>  Commit objects created with the above setting record the value
> -of `i18n.commitencoding` in its `encoding` header.  This is to
> +of `i18n.commitEncoding` in its `encoding` header.  This is to
>  help other people who look at them later.  Lack of this header
>  implies that the commit log message is encoded in UTF-8.
>  
> @@ -54,15 +54,15 @@ implies that the commit log message is encoded in UTF-8.
>    `encoding` header of a commit object, and try to re-code the
>    log message into UTF-8 unless otherwise specified.  You can
>    specify the desired output encoding with
> -  `i18n.logoutputencoding` in `.git/config` file, like this:
> +  `i18n.logOutputEncoding` in `.git/config` file, like this:
>  +
>  ------------
>  [i18n]
> -	logoutputencoding = ISO-8859-1
> +	logOutputEncoding = ISO-8859-1
>  ------------
>  +
>  If you do not have this configuration variable, the value of
> -`i18n.commitencoding` is used instead.
> +`i18n.commitEncoding` is used instead.
>  
>  Note that we deliberately chose not to re-code the commit log
>  message when a commit is made to force UTF-8 at the commit
Previous: Kaartic Sivaraam
Message 2 of 2 in “doc: camelCase the i18n config variables to improve readability”
  1. doc: camelCase the i18n config variables to improve readabilityKaartic Sivaraam, Jul 17, 2017
  2. Junio C HamanoJul 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.