Re: [PATCH 1/5] convert_to_git(): checksafe becomes an integer

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 5, 2018, 23:22 UTC
Message-ID: <xmqqincfao1b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <96B6CD4C-0A0C-47F5-922D-B8BAFB832FD1@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 15 quoted lines

>> On 31 Dec 2017, at 09:05, tboegi@web.de wrote:
>> 
>> From: Torsten Bögershausen <tboegi@web.de>
>> 
>> When calling convert_to_git(), the checksafe parameter has been used to
>> check if commit would give a non-roundtrip conversion of EOL.
>> 
>> When checksafe was introduced, 3 values had been in use:
>> SAFE_CRLF_FALSE: no warning
>> SAFE_CRLF_FAIL:  reject the commit if EOL do not roundtrip
>> SAFE_CRLF_WARN:  warn the user if EOL do not roundtrip
>
> In general, I really like the direction as this simplifies
> my patch later on in 5/5. However, I see a few problems:
> ...

Yes, this looks like a sensible way to go. I saw Torsten's v3 for 1/5 but will end up queuing v2b, as I suspect 5/5 would need to be adjusted for the change between the two versions.

Thanks.