Re: [PATCH v2] dir.c: ignore paths containing .git when invalidating untracked cache
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 13, 2018, 17:57 UTC
- Message-ID
- <xmqqinb0rcw5.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8AHa6QDmWu7TFjgW7m0pHysYkZq_WJ1QOVBVYaT4XdL4Q@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
> It's very tempting considering that the amount of changes is much > smaller. But I think we should go with my version. The hope is when a > _new_ call site appears, the author would think twice before passing > zero or one to the safe_path argument.
Wouldn't it be a better API if the author of new callsite does not have to think twice and can instead rely on the called function untracked_cache_invalidate_path() to always do the right thing?