git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: .gitattributes lookup doesn't respect GIT_WORK_TREE

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2018, 21:05 UTC
Message-ID
<xmqqin8s18pg.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<877ep8p9yz.fsf@linux-m68k.org>
Andreas Schwab <schwab@linux-m68k.org> writes:
> The functions in attr.c do not look at $GIT_WORK_TREE when trying to
> find the .gitattributes file.  Thus if you are not inside the work tree,
> but have GIT_WORK_TREE set attribute lookup will be wrong.

I may be mistaken (I do not have the code in front of me right now) but IIRC after the setup.c code runs (which happens quite early in the sequence that starts from git.c::cmd_main()), the Git process moves to the top level of the working tree, and at that point there is no reason to pay attention to $GIT_WORK_TREE or other mechanisms that places the working tree at a non-standard location, because the attributes (or any in-tree files like .gitignore or .gitmodules) will be found relative to the current working directory no matter what. Did we break that recently?

Previous: Andreas SchwabNext: Andreas Schwab
Message 2 of 4 in “.gitattributes lookup doesn't respect GIT_WORK_TREE”
  1. Andreas SchwabApr 15, 2018
  2. Junio C HamanoApr 15, 2018
  3. Andreas SchwabApr 15, 2018
  4. Duy NguyenApr 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.