Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 10, 2018, 15:58 UTC
- Message-ID
- <xmqqin5n9j6f.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180710153724.GA23438@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> On Fri, Jul 06, 2018 at 10:24:58AM -0700, Junio C Hamano wrote:
>
>> What we've been avoiding was the comma after the last element in the
>> enum (in other words, if PGP_FMT had ',' after it in the above
>> quoted addition, that would have been violation of that rule), as
>> having such a trailing comma used to be ANSI C violation as well. I
>> do not recall offhand if we loosened that deliberately.
>>
>> 4b05548f ("enums: omit trailing comma for portability", 2010-05-14),
>> c9b6782a ("enums: omit trailing comma for portability", 2011-03-16)
>
> I think we accidentally did a weather-balloon in e1327023ea (grep:
> refactor the concept of "grep source" into an object, 2012-02-02).
> It's still there and nobody has complained about it yet.
>
> So I think we can consider that requirement loosened at this point.
>
> -PeffYup, thanks for digging it out. It seems that I did the same digging some time ago but forgot about it.