Re: Test failures on OpenBSD

From

Junio C Hamano <gitster@pobox.com>

Date

Aug 23, 2018, 15:53 UTC

Message-ID

<xmqqin41jd05.fsf@gitster-ct.c.googlers.com>

In-Reply-To

<87a7pdfltp.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>     + echo Error (-1) reading configuration file a-directory.
>     + > expect 
>     + mkdir a-directory
>     + test_expect_code 2 test-tool config configset_get_value foo.bar a-directory
>     + 2> output 
>     Value not found for "foo.bar"
>     test_expect_code: command exited with 1, we wanted 2 test-tool config configset_get_value foo.bar a-directory
>     error: last command exited with $?=1
>     not ok 23 - proper error on directory "files"

I wonder why FreeBSD sets it but not OpenBSD in config.mak.uname.

>     + make_dir extract
>     + tar xf subtree-all.tar -C extract
>     tar: Cannot identify format. Searching...
>     tar: End of archive volume 1 reached
>     tar: Sorry, unable to determine archive format.
>     error: last command exited with $?=1

>     + seq 11
>     ./t5552-skipping-fetch-negotiator.sh: seq: not found

This must use test_seq.

 t/t5552-skipping-fetch-negotiator.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/t/t5552-skipping-fetch-negotiator.sh b/t/t5552-skipping-fetch-negotiator.sh
index 5ad5bece55..30857b84a8 100755
--- a/t/t5552-skipping-fetch-negotiator.sh
+++ b/t/t5552-skipping-fetch-negotiator.sh
@@ -46,7 +46,7 @@ test_expect_success 'commits with no parents are sent regardless of skip distanc
 	test_commit -C server to_fetch &&
 
 	git init client &&
-	for i in $(seq 7)
+	for i in $(test_seq 7)
 	do
 		test_commit -C client c$i
 	done &&
@@ -89,7 +89,7 @@ test_expect_success 'when two skips collide, favor the larger one' '
 	test_commit -C server to_fetch &&
 
 	git init client &&
-	for i in $(seq 11)
+	for i in $(test_seq 11)
 	do
 		test_commit -C client c$i
 	done &&
@@ -168,14 +168,14 @@ test_expect_success 'do not send "have" with ancestors of commits that server AC
 	test_commit -C server to_fetch &&
 
 	git init client &&
-	for i in $(seq 8)
+	for i in $(test_seq 8)
 	do
 		git -C client checkout --orphan b$i &&
 		test_commit -C client b$i.c0
 	done &&
-	for j in $(seq 19)
+	for j in $(test_seq 19)
 	do
-		for i in $(seq 8)
+		for i in $(test_seq 8)
 		do
 			git -C client checkout b$i &&
 			test_commit -C client b$i.c$j
@@ -205,7 +205,7 @@ test_expect_success 'do not send "have" with ancestors of commits that server AC
 
 	# fetch-pack should thus not send any more commits in the b1 branch, but
 	# should still send the others (in this test, just check b2).
-	for i in $(seq 0 8)
+	for i in $(test_seq 0 8)
 	do
 		have_not_sent b1.c$i
 	done &&