git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix pack protocol example client/server communication

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2019, 05:37 UTC
Message-ID
<xmqqimwg4uaj.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190316085707.4151-1-mh@glandium.org>
Mike Hommey <mh@glandium.org> writes:
> The pkt-line formatted lines contained the wrong pkt-len.
Wow.
Show 16 quoted lines
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>  Documentation/technical/pack-protocol.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
> index 7a2375a55d..c73e72de0e 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -657,14 +657,14 @@ can be rejected.
>  An example client/server communication might look like this:
>  
>  ----
> -   S: 007c74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\0report-status delete-refs ofs-delta\n
> +   S: 006274730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\0report-status delete-refs ofs-delta\n

This miscounts from the very beginning. I am not sure where the mistake came from originally.

>     S: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe refs/heads/debug\n
>     S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/master\n
> -   S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\n
> +   S: 003d74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\n

This too miscounts from the very beginning of this content; it is likely that it was copied and pasted from the line above, which does have a correct bytecount.

>     S: 0000
>  
> -   C: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\n
> -   C: 003e74730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\n
These are likely copy-and-paste from the above ;-)
> +   C: 00677d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\n
> +   C: 006874730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\n
I counted these myself before applying, and they look correct ;-)
Thanks.
>     C: 0000
>     C: [PACKDATA]
Previous: Mike Hommey
Message 2 of 2 in “fix pack protocol example client/server communication”
  1. fix pack protocol example client/server communicationMike Hommey, Mar 16, 2019
  2. Junio C HamanoMar 18, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.