git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ab/no-kwset, was Re: What's cooking in git.git (Jun 2019, #07; Fri, 28)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 1, 2019, 16:39 UTC
Message-ID
<xmqqimsl7lpn.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<nycvar.QRO.7.76.6.1907011515150.44@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 24 quoted lines
> Hi Junio & Ævar,
>
> On Fri, 28 Jun 2019, Junio C Hamano wrote:
>
>> * ab/no-kwset (2019-06-28) 9 commits
>>  - grep: use PCRE v2 for optimized fixed-string search
>>  - grep: remove the kwset optimization
>>  - grep: drop support for \0 in --fixed-strings <pattern>
>>  - grep: make the behavior for NUL-byte in patterns sane
>>  - grep tests: move binary pattern tests into their own file
>>  - grep tests: move "grep binary" alongside the rest
>>  - grep: inline the return value of a function call used only once
>>  - grep: don't use PCRE2?_UTF8 with "log --encoding=<non-utf8>"
>>  - log tests: test regex backends in "--encode=<enc>" tests
>>
>>  Retire use of kwset library, which is an optimization for looking
>>  for fixed strings, with use of pcre2 JIT.
>>
>>  Will merge to 'next'.
>
> There is still a test failure that I am not sure how Ævar wants to
> address:
>
> https://dev.azure.com/gitgitgadget/git/_build/results?buildId=11535&view=ms.vss-test-web.build-test-results-tab
Thanks for a quick response to stop me.

As this is a mere swapping-an-optimization-with-yet-another-one, I do not think we are in a hurry to have it graduate.

Previous: Johannes SchindelinNext: Ævar Arnfjörð Bjarmason
Message 3 of 12 in “What's cooking in git.git (Jun 2019, #07; Fri, 28)”
  1. Junio C HamanoJun 28, 2019
  2. ab/no-kwset, was Re: What's cooking in git.git (Jun 2019, #07; Fri, 28)Johannes Schindelin, Jul 1, 2019
  3. Junio C HamanoJul 1, 2019
  4. Ævar Arnfjörð BjarmasonJul 1, 2019
  5. Johannes SchindelinJul 2, 2019
  6. Rohit AshiwalJul 1, 2019
  7. Junio C HamanoJul 1, 2019
  8. Taylor BlauJul 1, 2019
  9. Junio C HamanoJul 1, 2019
  10. Taylor BlauJul 1, 2019
  11. Junio C HamanoJul 2, 2019
  12. Johannes SchindelinJul 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.