Re: What's cooking in git.git (Sep 2020, #03; Wed, 9)

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2020, 21:14 UTC
Message-ID: <xmqqimcezqs5.fsf@gitster.c.googlers.com>
In-Reply-To: <85ft7ivp1t.fsf@LAPTOP-ACER-ASPIRE-F5.i-did-not-set--mail-host-address--so-tickle-me>

jnareb@gmail.com (Jakub Narębski) writes:

Show 5 quoted lines

> Those are patches that are part of GSoC project of Shourya Shukla:
> 'Convert submodule to builtin'.
> ...
> Those are patches that are part of GSoC project of Hariom Verma:
> 'Unify ref-filter formats with other --pretty formats'

Yes and yes. What is your intention for highlighting that these two are GSoC originated projects, by the way?

These entries in the What's cooking report will eventually be part of the Release Notes, it is tempting to mention it there for publicity of the GSoC program (and I happen to work for OSPO that runs the program).

But at the same time, it becomes part of the published history (i.e. commit log for the merge commits) and over there, I am not sure if we want to mention GSoC---who the changes came from and in what context is much less important than what the actual changes are while reading the history of the project, trying to understand the current state of the code [*1*].

> I'd like to point out that latest series of patches by Abhishek Kumar
> which are final part of 'Implement Generation Number v2' is at what I
> believe is next to final iteration:

Yup, I've been watching from the sideline and appreciate that you've given the author quite a lot of help to make the series into a good shape.

Show 6 quoted lines

> Because corrected commit date offsets are not monotone, that is after
> value that doesn't fit in 32 bits (in parent) there can be one that does
> (in child).  It is extremely unlikely that in real repositories there
> would be that large corrections needed, but it can happen in theory, and
> therfore we need some way to handle overflow if we choose this option.
> And of course we should test that overflow handling works correctly.

My gut feeling is that overflow handling needs there whether the field is 32-bit or 64-bit.

Thanks.

[Footnote]

*1* Unless you want to have more cues to notice commits by less
    experienced contributors and want to focus more carefully while
    bisecting the history or something like that, that is.