git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 1/8] doc: propose hooks managed by the config

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 16, 2020, 17:29 UTC
Message-ID
<xmqqimbacc4q.fsf@gitster.c.googlers.com>
In-Reply-To
<87d01jih7w.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 11 quoted lines
> On Thu, Oct 15 2020, Emily Shaffer wrote:
>
>> Notes:
>>     Since v4, addressed comments from Jonathan Tan about wording.
>
> I had some extensive comments on the v4 here:
> https://lore.kernel.org/git/87mu0ygzk1.fsf@evledraar.gmail.com/
>
> Your CL & this patch don't mention it. I'd be interested in
> collaborating on this depending on if/how our goals/wants align, but I'd
> lke to get your thoughts on that feedback first.
True.

It seems that it wasn't responded (not even a single-liner "Thanks, I'll get to it later" or "Thanks, but the goal I am aiming is different from yours and your experience does not translate directly here") and I can only conclude that it somehow was overlooked?

Emily?

Side note: perhaps it is just me, but after making a review and giving extensive comments and suggestions, it is often disorienting to read the next round without getting any hint on which parts of the comments were heard and which other parts were dismissed (and why). I think your earlier review is a kind that deserves a separate response before the updated patchset.

Thanks.
Previous: Ævar Arnfjörð BjarmasonNext: Emily Shaffer
Message 7 of 12 in “propose config-based hooks (part I)”
  1. 0/8 propose config-based hooks (part I)Emily Shaffer, Oct 14, 2020
  2. 3/8 hook: add list commandEmily Shaffer, Oct 14, 2020
  3. 6/8 parse-options: parse into strvecEmily Shaffer, Oct 14, 2020
  4. 8/8 hook: replace find_hook() with hook_exists()Emily Shaffer, Oct 14, 2020
  5. 1/8 doc: propose hooks managed by the configEmily Shaffer, Oct 14, 2020
  6. Ævar Arnfjörð BjarmasonOct 15, 2020
  7. Junio C HamanoOct 16, 2020
  8. Emily ShafferOct 21, 2020
  9. 5/8 hook: implement hookcmd.<name>.skipEmily Shaffer, Oct 14, 2020
  10. 4/8 hook: include hookdir hook in listEmily Shaffer, Oct 14, 2020
  11. 2/8 hook: scaffolding for git-hook subcommandEmily Shaffer, Oct 14, 2020
  12. 7/8 hook: add 'run' subcommandEmily Shaffer, Oct 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.