git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect: peel annotated tags to commits

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 17, 2021, 18:24 UTC
Message-ID
<xmqqim5pwse4.fsf@gitster.g>
In-Reply-To
<YFDLq9mLbJtLqKea@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
>> Looks like it bisects to 27257bc466 (bisect--helper: reimplement
>> `bisect_state` & `bisect_head` shell functions in C, 2020-10-15), which
>> isn't too surprising. So it broke in v2.30, but nobody seems to have
>> noticed during the last cycle.
>> 
>> I'd guess it's just missing a call to peel the input oid.
>
> Yep. Here's a fix. Again, not new in v2.31, so we don't have to worry
> about a brown-bag fix for yesterday's release. But I do think it's worth
> trying to get onto a maint release. I prepared this patch on top of
> mr/bisect-in-c-3.

Thanks. Yes, if we ever do another update to 2.30.x, this probably should be in it, as it is expected that people will start with tags and not with individual commits.

Previous: Bagas Sanjaya
Message 5 of 5 in “git bisect fails to handle annotated tags”
  1. Andreas SchwabMar 16, 2021
  2. Jeff KingMar 16, 2021
  3. bisect: peel annotated tags to commitsJeff King, Mar 16, 2021
  4. Bagas SanjayaMar 17, 2021
  5. Junio C HamanoMar 17, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.