Re: [PATCH v9] builtin/clone.c: add --reject-shallow option

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2021, 22:37 UTC
Message-ID: <xmqqim5754rl.fsf@gitster.g>
In-Reply-To: <nycvar.QRO.7.76.6.2104010021510.54@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 8 quoted lines

>> Does this "single variable is enough" really work?
>> ...
> That's my mistake, and you don't even need a second config to see the
> problem:
>
> 	[clone]
> 		rejectShallow = false
> 		rejectShallow = true

Yup, that is a much simpler example.

> Sorry for the trouble!

Don't feel bad---in an earlier round of review I made a similar mistake to wonder if these two variables can be reduced into one myself ;-). As you said, this one is special in making two calls to git_config() and need to be handled carefully.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.