Re: [PATCH v4] t6030: add test for git bisect skip started with --term* arguments
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2021, 08:20 UTC
- Message-ID
- <xmqqim45h585.fsf@gitster.g>
- In-Reply-To
- <CAP8UFD23Wvm-SpoAoFZZWXfXO_KGPdT5vwa4gWXMbtgL66me=w@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 6 quoted lines
> I am not sure how safe it is to use the hash of a commit that is in > seen but not yet in next. I suggested using "a previous commit" > instead as I thought that both the fix and this commit should be part > of the same branch, and then it would be obvious which commit it is. > Maybe we should wait for Junio to come back from vacation and decide > about this.
It is totally unsafe. Besides, I do not think it is worth to make the fix and the test as two separate commits---can I ask you to help coordinate co-authorship between Ramsay and Bagas to come up with a combined single patch?
Thanks.