Re: [PATCH] t5582: remove spurious 'cd "$D"' line

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2021, 16:42 UTC
Message-ID: <xmqqilzm6g10.fsf@gitster.g>
In-Reply-To: <20210828094726.GG2257957@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 13 quoted lines

> On Wed, Aug 25, 2021 at 09:12:37AM -0700, Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:
>> 
>> > Hmm. I think that one is different, in that the "cd" is not redundant,
>> > but wrong. But it turns out not to matter to the test. ;)
>> 
>> Funny. 
>> 
>> We are lucky because 'cd ""' stays in the same repository as the
>> current one and not to a random place,
>
> Actually, the results of 'cd ""' are unspecified, though most shells
> do as you said.  Do we want something like this?

I doubt it, as the root issue is not "cd" but "$D" and other variables that we use before setting.

I wonder how close our test suite is for being "set -u" clean. Running our tests under "set -u" may not be a bad endpoint, but only if we can get there without too much pain.

Thanks.