Re: [PATCH] mergetool: new config guiDefault supports auto-toggling gui by DISPLAY

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 14, 2022, 15:37 UTC
Message-ID: <xmqqilkmbelx.fsf@gitster.g>
In-Reply-To: <CAPMMpoiwnLyqzBBubkgSpjyJQqSeEVdoZy72FAwGDbMgg9UXxg@mail.gmail.com>

Tao Klerks <tao@klerks.biz> writes:

> My understanding, from ad-hoc testing, is that using OPT_BOOL causes
> the target variable ("use_gui_tool" in this case) to *always* be set
> to either "1" or "0", regardless of whether the user sets the main
> flag, the --no form of the flag, or sets nothing at all.

You are saying "git gc --keep-largest-pack" is broken ;-)

OPT_BOOL() and OPT_BOOL_F() are OPT_SET_INT() in disguise and there is no "set to this default value if no command line option is given" involved. At least I do not recall allowing such a code in.

Thanks.