Re: [PATCH] am: don't pass strvec to apply_parse_options()

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2022, 02:42 UTC
Message-ID: <xmqqili9xwj8.fsf@gitster.g>
In-Reply-To: <Y546bgdvYIkfwTlv@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

>> Making a shallow copy to give to parse_options() in callers that currently
>> pass a strvec directly or indirectly seems like the simplest solution to
>> me for now.
>
> Yes, I thought your original patch actually got to the root of the
> problem. strvec owns the array and its elements, and parse-options wants
> to munge the array itself (but not the elements). Making a shallow copy
> is eliminates the conflict over ownership.

Yup, it did look very sensible to me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.