Re: [PATCH v3] name-rev: fix names by dropping taggerdate workaround
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2023, 17:10 UTC
- Message-ID
- <xmqqilgaojci.fsf@gitster.g>
- In-Reply-To
- <pull.1468.v3.git.1675933906906.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> - /* > - * When comparing names based on tags, prefer names > - * based on the older tag, even if it is farther away. > - */ > + /* If both are tags, we prefer the nearer one. */ > if (from_tag && name->from_tag) > - return (name->taggerdate > taggerdate || > - (name->taggerdate == taggerdate && > - name_distance > new_distance)); > + return name_distance > new_distance;
OK.
Show 7 quoted lines
> - /* > - * We know that at least one of them is a non-tag at this point. > - * favor a tag over a non-tag. > - */ > + /* Favor a tag over a non-tag. */ > if (name->from_tag != from_tag) > return from_tag;
The removed sentence is not something whose validity has changed due to the code change. We still know at this point one of from_tag or name->from_tag is false, thanks to the previous check, whose condition did not change (only what is returned when the condition holds changed). But it may be obvious to readers, so, ... OK.